Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Services 1085 save inactive items and db validation 2 #960

Open
wants to merge 18 commits into
base: development
Choose a base branch
from
Open

Services 1085 save inactive items and db validation 2 #960

wants to merge 18 commits into from

Conversation

johnykes
Copy link
Contributor

@johnykes johnykes commented Mar 23, 2023 •
edited
Loading

  • hybrid/partial reindex states (Partial items from marketplaceReindexState can be in DB and some in Memory, without any problems)

PS:

  1. there are few places where the code is a bit complicated, because it's hard to find corresponding Auctions for Orders, or corresponding in memory Orders for DB Orders 😢 ; Solution: also add marketplaceAuctionId column in orders table, or create marketplaceOrderId in SC & table.
  2. the items' IDs have negative values by default (e.g. auctionsTemporaryIdCounter = -1), so it ca be easier to find out if an item was saved in DB or is just in memory

@danielailie danielailie force-pushed the SERVICES-1085-save-inactive-items-and-db-validation branch from 0abb1ca to 61be3cc Compare November 8, 2023 11:38
Base automatically changed from SERVICES-1085-save-inactive-items-and-db-validation to development November 8, 2023 11:49
@danielailie danielailie force-pushed the SERVICES-1085-save-inactive-items-and-db-validation-2 branch from d5deab9 to 7bf7cf0 Compare November 8, 2023 11:56
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2023 •
edited
Loading

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (61be3cc) 42.88% compared to head (7b9b860) 42.47%.
Report is 3 commits behind head on development.

❗ Current head 7b9b860 differs from pull request most recent head c0eb5ea. Consider uploading reports for the commit c0eb5ea to get more accurate results

Files Patch % Lines
src/db/auctions/auctions.repository.ts 8.57% 24 Missing and 8 partials ⚠️
src/db/orders/orders.repository.ts 0.00% 15 Missing and 8 partials ⚠️
src/db/offers/offers.repository.ts 0.00% 9 Missing and 4 partials ⚠️
src/db/auctions/tags.repository.ts 0.00% 9 Missing and 3 partials ⚠️
src/common/persistence/persistence.service.ts 0.00% 5 Missing ⚠️
src/modules/auctions/auctions-setter.service.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           development     #960      +/-   ##
===============================================
- Coverage        42.88%   42.47%   -0.41%     
===============================================
  Files              395      395              
  Lines             8281     8364      +83     
  Branches           952      975      +23     
===============================================
+ Hits              3551     3553       +2     
- Misses            3828     3886      +58     
- Partials           902      925      +23
Flag Coverage Δ
unittests 42.47% <3.37%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnykes @danielailie